Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #663 local jump error due to lack of block passing for recording list #664

Closed
wants to merge 1 commit into from
Closed

fix: #663 local jump error due to lack of block passing for recording list #664

wants to merge 1 commit into from

Conversation

JYorston
Copy link
Contributor

@JYorston JYorston commented Jun 16, 2023 •
edited
Loading

Fix local jump error due to lack of block passing for recording list.

Fixes

#663

It appears after a recent merge that the block passed to the seralize_list method was removed in the recordings file:
JYorston@1956b94

This is causing a local_jump_error when trying to list recordings on the latest Gem version.

I added the block back in and verified that it is now working as expected.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@JYorston
Fix local jump error due to lack of block passing for recording list
1f45516 
Fix local jump error due to lack of block passing for recording list
@JYorston JYorston changed the title #663 Fix local jump error due to lack of block passing for recording list fix: #663 local jump error due to lack of block passing for recording list Jun 16, 2023
@JYorston JYorston mentioned this pull request Jun 16, 2023
Open
@JYorston JYorston changed the title fix: #663 local jump error due to lack of block passing for recording list fix #663 local jump error due to lack of block passing for recording list Jun 16, 2023
@JYorston JYorston changed the title fix #663 local jump error due to lack of block passing for recording list fix #663 local jump error due to lack of block passing for recording list Jun 16, 2023
@JYorston JYorston changed the title fix #663 local jump error due to lack of block passing for recording list fix: #663 local jump error due to lack of block passing for recording list Jun 16, 2023
@JYorston JYorston closed this Jun 16, 2023
@JYorston JYorston deleted the patch-1 branch June 16, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JYorston