Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for media recordings #140

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Add support for media recordings #140

wants to merge 45 commits into from

Conversation

timrozum
Copy link
Contributor

  1. Add recording support to the web app, iOS app, and reference backend. The event host can enable recording in the app UI when they create the event.
  2. Display alert when a user joins a stream to explain that recording is enabled.
  3. Display recording indicator while stream is in progress to indicate recording is ongoing.
  4. Use npm run recordings to view recordings.
  5. Refactor error handling in the reference backend to increase code reuse and make the code easier to follow.

Tim Mendoza and others added 30 commits March 22, 2022 21:01
Refactor error handling in create-stream.js
c2dd174
Create stream document in create-stream route
71e6a95
Refactor create-stream a little more
a20aa69
Refactor errors in join-stream; add permissions to stream document
059aa90
Refactor error handling in join-stream; add permissions to stream doc
d161ee3
Fix bug in record stream
39051bf
@timrozum
Display recording status
a0caf7b
Fix proxy
30f2190
Add checkbox to enable recordings
3d9bd8a
Update useIsRecording to listen to StreamDocument updates
63ed6f4
Add mock media-processor-webhook endpoint
816d80d
Fix if statement
b719dcc
Merge branch 'update-functions-to-support-recording' into add-recordi…
e9bcb78 
…ng-ui-web
@timrozum
Minor fixes
22dd9f6
Add recording indicator to the Player component
a1c4cae
Add recording error to useIsRecording hook
b2a490e
Update usage of useIsRecording Hook
1511e03
Add useRecordingNotifications hook
5485fc9
Fix positioning of the Recording bagde
5744626
Remove old RecordingNotifications component
6aef4c4
Update useRecordingNotifications
803d6fe
Refactor delete-stream function
66d61c6
Refactor raise-hand endpoint
6fccd4e
Refactor viewer-connected-to-player endpoint
67ce197
Refactor sync-webhook
a0c832b
Refactor rooms-webhook
8d287aa
@timrozum
Merge branch 'main' into task/recording
df7f3b0 
# Conflicts:
#	apps/ios/LiveVideo/LiveVideo/Launch/LiveVideoApp.swift
#	apps/ios/LiveVideo/LiveVideo/Twilio/Sync/SyncManager.swift
Merge branch 'update-functions-to-support-recording' into add-recordi…
e9f2473 
…ng-ui-web
Fix typos
42600c3
Remove sync_object_names
441b114
timmydoza and others added 15 commits June 9, 2022 15:04
Merge pull request #111 from twilio/update-functions-to-support-recor…
c3f223f 
…ding

Update functions to support recording
Merge pull request #112 from twilio/add-recording-ui-web
1793ed2 
Add recording UI web
@timrozum
Merge pull request #108 from twilio/task/recording
88f1f41 
iOS app recording feature
@timrozum
Merge branch 'main' into feature/recording-web
b4f6fec
@timrozum
Configure recording when creating media processor
8d0715e
@timrozum
Handle recording error in media processor callback
164e636
@timrozum
Update readme
a439600
@timrozum
Add recordings script
cd80428
@timrozum
Add date updated to the recordings script output
ed09d19
@timrozum
Recording script improvements
4601d52
@timrozum
Use multiple lines to output each recording
b85ac73
@timrozum
Tiny code format change
cbc04bf
@timrozum
Merge pull request #133 from twilio/connect-recording-to-api
e2881b2 
Connect recording API
@timrozum
Update readme
c76acf3
@timrozum
Merge pull request #139 from twilio/task/update-readme
6987c59 
Small readme change
timrozum
timrozum commented Jun 29, 2022
View reviewed changes
serverless/constants.js
@@ -1,7 +1,7 @@
const syncServicePrefix = 'Live Video '

module.exports = {
MEDIA_EXTENSION: 'video-composer-v1',
MEDIA_EXTENSION: 'video-composer-v1-test',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change this to video-composer-v2 eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@timrozum