Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency Warning and Build Issues #125

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Dependency Warning and Build Issues #125

merged 2 commits into from
Oct 30, 2023

Conversation

josethepm
Copy link
Collaborator

  • Resolved unmet / incorrect / other dependency warnings across the install and build
  • Cleared up a few style issues

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

josethepm
josethepm commented Oct 12, 2023
View reviewed changes
src/components/Avatar.tsx
@@ -1,6 +1,6 @@
import { Avatar as PasteAvatar } from "@twilio-paste/avatar";
import { UserIcon } from "@twilio-paste/icons/cjs/UserIcon";
import { IconSize } from "@twilio-paste/style-props";
import type { IconSize } from "@twilio-paste/style-props";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this here was crashing my Vercel build, but honestly not sure.

@camr1993 camr1993 mentioned this pull request Oct 20, 2023
Open
lesquive
lesquive approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@lesquive lesquive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good on this PR. I've tested it locally, and the main branch compilation errors are no longer occurring. This is an important PR to address the issue reported in #124.

@berkus berkus merged commit b49bbdb into twilio:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesquive lesquive lesquive approved these changes

@berkus berkus berkus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josethepm @berkus @lesquive