Fix endless ringing in ring-notification #701
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When receiving multiple tasks, and they are both alerting at the same time, we would overwrite the
mediaId
of the first task, so we could not stop it when accepting. We avoid that scenario by returning in theplay
function if we are already playing.As an initial attempt at the fix, I tried stopping the initial media when the second
play
was invoked, however, I found that in the case multiple reservations come to you at the same time, thestop
would not actually prevent it playing when it was called before the audio file loaded. This may be an issue with the FlexAudioPlayerManager
, but I did not look into this much further as the solution I landed upon seems to work well.Checklist