-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(design-tokens): add elevation tokens #4207
base: main
Are you sure you want to change the base?
Conversation
nkrantz
commented
Jan 14, 2025
- Add and adjust tokens from Elevation Foundations Kickoff
- Add ability to hide certain tokens from tokens list on docs site
Run & review this pull request in StackBlitz Codeflow. |
🦋 Changeset detectedLatest commit: af9fa1b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit af9fa1b.
☁️ Nx Cloud last updated this comment at |
Size Change: +5.48 kB (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit af9fa1b:
|
Paste Run #9301
Run Properties:
|
Project |
Paste
|
Branch Review |
elevation-token-updates
|
Run status |
Passed #9301
|
Run duration | 01m 56s |
Commit |
af9fa1b60a: Merge branch 'main' into elevation-token-updates
|
Committer | Nora Krantz |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
67
|
View all changes introduced in this branch ↗︎ |
packages/paste-design-tokens/tokens/themes/twilio-dark/global/background-color.yml
Outdated
Show resolved
Hide resolved
packages/paste-design-tokens/tokens/themes/dark/aliases/color.yml
Outdated
Show resolved
Hide resolved
packages/paste-design-tokens/tokens/themes/evergreen/aliases/color.yml
Outdated
Show resolved
Hide resolved
packages/paste-design-tokens/tokens/themes/dark/global/box-shadow.yml
Outdated
Show resolved
Hide resolved
packages/paste-design-tokens/tokens/themes/dark/global/box-shadow.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phew that was a lot of changes! Really solid changes, I left a few comments for discrepancies I found compared to the docs file and some refactor questions (should the palette-black now be moved to the color-palette.yml files)
packages/paste-design-tokens/tokens/themes/dark/global/box-shadow.yml
Outdated
Show resolved
Hide resolved
2d16247
to
c86ebb6
Compare
Paste Run #9302
Run Properties:
|
Project |
Paste
|
Branch Review |
elevation-token-updates
|
Run status |
Passed #9302
|
Run duration | 05m 59s |
Commit |
f1335dcd20 ℹ️: Merge af9fa1b60aea1d21306e8387d2604be042c4b1fd into f3a48a4b1768694b490fd77b9246...
|
Committer | Nora Krantz |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
125
|
View all changes introduced in this branch ↗︎ |