refactor(model, cache): a full message object for MessageUpdate event
#2387
+54
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-cache
Erk-
requested changes
Nov 24, 2024
Comment on lines
+8
to
+19
| impl Deref for MessageUpdate { | ||
| type Target = Message; | ||
|
|
||
| fn deref(&self) -> &Self::Target { | ||
| &self.0 | ||
| } | ||
| } | ||
|
|
||
| impl DerefMut for MessageUpdate { | ||
| fn deref_mut(&mut self) -> &mut Self::Target { | ||
| &mut self.0 | ||
| } |
There was a problem hiding this comment.
There is a discussion to have about if we should have these implementations, but that should probably be delegated to its own discussion because we have it multiple places.
There was a problem hiding this comment.
I see. So, this is good for now until we make decisions about these implementations.
Erk-
approved these changes
Nov 25, 2024
itohatweb
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessageUpdateevent now contains a fullMessageobject.Refs: