Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http, validate)!: channel user limits #2077

Merged
merged 3 commits into from
Jan 28, 2023

Conversation

zeylahellyer
Copy link
Member

Validate channel user_limit fields on UpdateChannel and CreateGuildChannel, introducing a new user_limit function in twilight_validate::channel.

Part of #1477.

Validate channel `user_limit` fields on `UpdateChannel` and
`CreateGuildChannel`, introducing a new `user_limit` function in
`twilight_validate::channel`.

Part of #1477.
@github-actions github-actions bot added c-http Affects the http crate c-validate Affects the validate crate m-breaking change Breaks the public API. t-feature Addition of a new feature labels Jan 19, 2023
Copy link
Member

@Erk- Erk- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit, but otherwise good so I approve it with that change

twilight-validate/src/channel.rs Outdated Show resolved Hide resolved
@7596ff 7596ff merged commit e7f2bb2 into next Jan 28, 2023
@7596ff 7596ff deleted the zeyla/feat-http-validate-channel-user-limit branch January 28, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-http Affects the http crate c-validate Affects the validate crate m-breaking change Breaks the public API. t-feature Addition of a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants