Bump Phpstan to level 4 #4494
Merged
Bump Phpstan to level 4 #4494
+23
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
Dec 2, 2024
| @@ -362,7 +365,7 @@ private function filterBodyNodes(Node $node, bool $nested = false): ?Node | |||
| // we need to discard the wrapping "Node" for the "body" node | |||
| $nested = $nested || !$node instanceof Nodes; | |||
| foreach ($node as $k => $n) { | |||
| if (null !== $n && null === $this->filterBodyNodes($n, $nested)) { | |||
There was a problem hiding this comment.
node is @implements \IteratorAggregate<int|string, Node> so $n is never null.
Closed
fabpot
reviewed
Dec 2, 2024
src/Error/Error.php
Outdated
| } else { | ||
| $name = json_encode($this->name); | ||
| } | ||
| $name = \sprintf('"%s"', $this->name); |
There was a problem hiding this comment.
As $name is not used anywhere else, maybe we can merge this line with the next?
There was a problem hiding this comment.
Yes, Done in 8a2f2c0
|
Thank you @VincentLanglet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.