Update coding standards #4488
Merged
Update coding standards #4488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
Nov 30, 2024
|
|
||
| * Put exactly one space after the ``:`` sign in macro argument declarations: | ||
| * Put exactly one space after the ``:`` sign when using named arguments: |
There was a problem hiding this comment.
I'm not sure it's worth mentioning a standard for named argument with = since
Use : instead of = to separate argument names and values:
{{ data|convert_encoding(from: 'iso-2022-jp', to: 'UTF-8') }}
fabpot
reviewed
Nov 30, 2024
doc/coding_standards.rst
Outdated
|
|
||
| .. code-block:: twig | ||
|
|
||
| {% macro html_input(class: "input") %} | ||
| {% html_input(class: "input") %} |
There was a problem hiding this comment.
Suggested change
| {% html_input(class: "input") %} | |
| {{ html_input(class: "input") }} |
?
There was a problem hiding this comment.
Indeed, updated
fabpot
force-pushed
the
codingStandards
branch
from
3929ed0
to
07a4ed1
Compare
|
Thank you @VincentLanglet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.