Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of visualise #801

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

yannham
Copy link
Member

@yannham yannham commented Dec 5, 2024

Improve visualise documentation

Context

I tried to use topiary visualise for the first time, and while the feature is cool, it took me a bit of time to understand how to get a final image that I could look at.

The first detail is that given the command name and help message, I somehow expected (maybe naively in retrospective) that I would get some sort of direct visualisation, either as ASCII art or by generating an image directly.

The second issue was that the format of the output wasn't easy to find (DOT) so I didn't know what to do with the output (well, I somehow suspected it was DOT, but only because I happen to have worked with dot files a long time ago). Once again, in retrospective, I just had to look at the --format argument description, but I stopped at the extended description (which is the same as the short description) and expected to find information there.

Description

This PR tries to make it clear, both in the README and in the command extended description, that visualise output raw graph data that needs to be rendered by an external tool, that the default format is DOT and that Graphviz is a recommended go-to solution for that.

Checklist

Checklist before merging:

  • CHANGELOG.md updated
  • README.md up-to-date

@yannham yannham self-assigned this Dec 5, 2024
Makes it clear, both in the README and in the command extended
description, that visualise output raw graph data that needs to be
rendered by an external tool, which wasn't entirely clear from the name
of the command and the commend help message at first sight.
@yannham yannham force-pushed the docs/improve-help-visualize branch from fcb2b73 to d2de2e7 Compare December 5, 2024 14:08
Copy link
Member

@Xophmeister Xophmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yannham 🙏

@nbacquey nbacquey merged commit 6b2e3c7 into main Dec 5, 2024
9 checks passed
@nbacquey nbacquey deleted the docs/improve-help-visualize branch December 5, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants