Fix genrule usage with runfiles #95
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
fix-runfiles-in-genrule
branch
from
2e5ed5e to
d3a3f7b
Compare
|
FYI @aherrmann |
avdv
force-pushed
the
fix-runfiles-in-genrule
branch
from
d3a3f7b to
8d69865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap tools with runfiles in shell/bat script that sets the runfiles variables if not set. This allows use of tools with runfiles without any manual setup.
TODO: This doesn't work for hermetic toolchains and/or tools in deps yet as the referenced dummy executable changes. I can look into fixing that if the general approach looks good to you.