Skip to content

Commit

Permalink
workflows fixed (#80)
Browse files Browse the repository at this point in the history
### To be filled by the PR creator:

* A brief description of the changes made - 

* Do we have clean latest run report (Docker or Browserstack) attached
with this PR?
  * [ ] Yes
  * [ ] No (Please explain why)

* Does the PR contain changes to any core file?
  * [ ] Yes (Needs approval from at least 1 people)
  * [ ] No

* Is it
  * [ ] New Testcase
  * [ ] Fix


### To be filled by the PR reviewer:

* [ ] Verify the attached run report passed in GitHub Actions (Docker or
Browserstack run)

* General
    * [ ] Use the best strategy to locate the elements
    * [ ] Comments wherever the code is not readable by itself
    * [ ] Use of the right data structure for the use case
    * [ ] Reuse logic/functionality as much as possible
    * [ ] Cleanup of any test data that is generated by the tests
    * [ ] No static waits
  • Loading branch information
Tauqir Sarwar authored Apr 1, 2024
2 parents d4b2df8 + 7df69b4 commit 6b0874b
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 17 deletions.
31 changes: 15 additions & 16 deletions .github/workflows/ui_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ env:
BROWSERSTACK_ACCESS_KEY: ${{secrets.BROWSERSTACK_ACCESS_KEY}}
HRM_USER_NAME: ${{ secrets.HRM_USER_NAME }}
HRM_PASSWORD: ${{ secrets.HRM_PASSWORD }}
# TESTRAIL_PROJECT_ID: "120"
# TEST_PLAN_ID: "15095"
# TESTRAIL_PROJECT_ID: "10"
# TEST_PLAN_ID: "195"

on:
schedule:
Expand All @@ -34,6 +34,15 @@ on:
required: true
default: https://opensource-demo.orangehrmlive.com

os:
description: 'Operating system (window or mac)'
required: true
type: choice
default: mac
options:
- mac
- window

browser:
description: Browser Name
required: true
Expand All @@ -44,14 +53,6 @@ on:
- firefox
- edge
- safari
os:
description: 'Operating system (window or mac)'
required: true
type: choice
default: mac
options:
- mac
- window

jobs:
web-scheduled-regression:
Expand Down Expand Up @@ -221,11 +222,6 @@ jobs:
exit 1
fi
if [[ "${{ inputs.os }}" == "mac" && "${{ inputs.browser }}" == "edge" ]]; then
echo "Invalid input: Edge is not supported on MAC OS."
exit 1
fi
- name: Setup Python
id: setup_python
if: steps.validate_input.outcome == 'success'
Expand Down Expand Up @@ -291,7 +287,10 @@ jobs:
if [[ "${{ github.event.inputs.browser }}" == "safari" && "${{ github.event.inputs.os }}" == "mac" ]]; then
BROWSER=./env_configs/mac_safari.json
fi
if [[ "${{ github.event.inputs.browser }}" == "edge" && "${{ github.event.inputs.os }}" == "mac" ]]; then
BROWSER=./env_configs/mac_edge.json
fi
env
source $HOME/.bp-venv/bin/activate
sh ci_run_web.sh ${{secrets.BROWSERSTACK_API_USERNAME}} ${{secrets.BROWSERSTACK_ACCESS_KEY}} "$BROWSER" "$TAGS" "$BASE_URL" "${{secrets.SLACK_WEBHOOK_URL}}" "${{secrets.TEAMS_WEBHOOK_URL}}"
Expand Down
2 changes: 1 addition & 1 deletion frontend/test_project/features/web/login_tests.feature
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Feature: OrangeHRM Login and Modus QA blog
And I click item 'Logout' for element 'OrangeHRM > logout_button'
Then The element 'OrangeHRM > username' is displayed

# This test case fails on Edge browser, because success message is not displayed after adding user (application issue)
# This test case fails on Edge browser (Linux), because success message is not displayed after adding user (application issue)
@hrm_add_user @automated
Scenario: Login and add admin user in OrangeHRM system
Given I set web base url '{%BASE_URL%}'
Expand Down

0 comments on commit 6b0874b

Please sign in to comment.