Skip to content

Commit

Permalink
Develop (#23)
Browse files Browse the repository at this point in the history
### To be filled by the PR creator:

* A brief description of the changes made - 

* Do we have clean latest run report attached with this PR?
  * [ ] Yes
  * [ ] No (Please explain why)

* Does the PR contain changes to any BP core file?
  * [ ] Yes (Needs approval from at least 2 people)
  * [ ] No

* Does the PR contain changes to modules shared with other teams?
* [ ] Yes (Needs approval from at least one of the other teams that use
the module)
  * [ ] No

* Is it
  * [ ] New Testcase
  * [ ] Fix


### To be filled by the PR reviewer:

* [ ] Verify the attached run report passed in GitHub Actions (Justify
if local run)

* General
    * [ ] Use the best strategy to locate the elements
    * [ ] Comments wherever the code is not readable by itself
    * [ ] Use of the right data structure for the use case
    * [ ] Reuse logic/functionality as much as possible
    * [ ] Cleanup of any test data that is generated by the tests
    * [ ] No static waits
  • Loading branch information
Tauqir Sarwar authored Mar 17, 2024
2 parents bc231a6 + e695aff commit 6a250ed
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/api_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
fi
source $HOME/.bp-venv/bin/activate
sh api_run.sh "$TAGS"
sh api_run.sh "$TAGS" "${{secrets.SLACK_WEBHOOK_URL}}" "${{secrets.TEAMS_WEBHOOK_URL}}"
- name: Get Allure history
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion api_run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
# Run API tests
python -m pytest -v -s --gherkin-terminal-reporter --html="./output/reports/" --tags=$1 --self-contained-html --reruns 1 --reruns-delay 2 --alluredir=allure-results \
--slack-webhook-url=$2 --slack-channel=pytest-test-automation --slack-results-url=https://tweag.github.io/pytest-automation-boilerplate --teams-webhook-url=$3 \
--teams-results-url=https://tweag.github.io/pytest-automation-boilerplate/
--teams-results-url=https://tweag.github.io/pytest-automation-boilerplate
8 changes: 1 addition & 7 deletions bp_core/notifications/teams_plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def create_message(self) -> dict:
{
"name": "View detail test report",
"targets": [
{"os": "default", "uri": "http://localhost:63342/pytest-automation-boilerplate/output/allure/reports/index.html"}
{"os": "default", "uri": self.results_url}
],
"@type": "OpenUri",
}
Expand All @@ -140,12 +140,6 @@ def create_message(self) -> dict:
'addImage': 'https://docs.pytest.org/en/latest/_static/favicon.png',
}







return message

def send_teams_message(self) -> requests.Response:
Expand Down

0 comments on commit 6a250ed

Please sign in to comment.