This repository has been archived by the owner on Feb 10, 2021. It is now read-only.
Implement Signature: header verification for Travis
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This theoretically addresses #43, though ideally we should fetch Travis' public key ourselves rather than requiring the user to copy it into the settings file themself.
cvrebert
force-pushed
the
travis-verify
branch
from
7f7faac
to
8b093a9
Compare
|
Happy to give it a go @cvrebert. Should be able to test and report back today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This theoretically addresses #43, modulo one usability nit.
Haven't had a chance to test it out though.
@bobholt @Blackbaud-BobbyEarl I'd appreciate it if one of you could take this for a spin and see whether it works in practice.