Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Download): Fix download and extract for Linux #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nokome
Copy link

@nokome nokome commented Jul 5, 2022

This removes --strip-components=1 when extracting the tar.gz which fixes installs on Linux. Tested with v4.1.1 and v3.4.4 (not all releases have binaries it seems) e.g.

asdf plugin test podman https://github.com/nokome/asdf-podman.git "podman --version"
Updating podman to master
fatal: couldn't find remote ref master
fatal: Needed a single revision
error: pathspec 'master' did not match any file(s) known to git
* Downloading podman release 4.1.1...
podman version 4.1.1

Also fixes the release_file path and extract method for MacOS but the download URL looks wrong and I haven't tested at all.

@rm3l
Copy link

rm3l commented Mar 12, 2023

Hi there!

Can we please have this PR reviewed and merged? I'd be interested in having this plugin work on Linux.
Thanks.

Copy link

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nokome I just tested this using your fork, and was not able to make it work on Linux (using Fedora):

$ asdf plugin add podman https://github.com/nokome/asdf-podman.git 
$ asdf install podman latest                                      
* Downloading podman release 4.4.2...
curl: (22) The requested URL returned error: 404
asdf-podman: Could not download https://github.com/containers/podman/releases/download/v4.4.2/podman-remote-static.tar.gz

I guess something has changed in the way the archives are named (I see it is now called podman-remote-static-linux_amd64.tar.gz).. Maybe you could handle such case as well?

@damdo
Copy link
Contributor

damdo commented Aug 30, 2023

I've extended this fix to other issues I found along this line, see #2

@tvon
Copy link
Owner

tvon commented Aug 31, 2023

#2 has been merged, if that resolves things then please close this.

I’m on vacation and will not be able to dig into anything until Tuesday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants