[WIP] Adding color directions #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added file for experimentation * added SH implementation with 2 parameters * adjusted script * added coefficients to experimental implementation * deleted unused variables * added files for experimentation on each issue * added file for experimentation with textures * updated files * passing coefficients through texture with few glyphs * comparison of passing coefficients with uniforms vs texture * Pruning duplicate coeffs. * Refactoring FS declaration code. * Added temp call to Fury's Central Differences Normals calculation. * Added new file with changes. * Restored texture_coefficients.py * organized files * adjusted uv vals * Added minor changes. * added new file for SH efficient implementation * Minor changes in shader code. * Added first version of Peters' paper. * Added difinitions for constants. * Added first functions of main shaders. * All functions added. * clear * Removed rotation code and resolution dependent code. * Renamed folder spherical_harmonics as rt_odfs. * Organized main code. * Created ray_traced_3.py to simplify ray_traced_1.py content. Removed BRDF functions. * added SH efficient implementation to the base impl with texture * Added minor changes to base Ray Tracing implementation (ray_traced_1.py). * Minor changes on ray_traced_3.py. * Minor changes in ray_traced_1.py * Forwarded camera right and up vectors. * Used 3D point as frag_coord for uv mapping. * Tournier first implementation * updated files * added Tournier impl * Improved description of ray_traced_3.py * Prep for new ray_traced file. * Minor changes to ray_traced3.py * Created ray_traced_6.py to fix scalability. * Minor changes to ray_traced_6.py * Added README and renamed ray_traced files. * Added ray_traced_4.0.py as an analogous version of ray_traced_2.0.py. Updated README. * Removed ray_traced_6.0.py from PR. * implementation with a slice * made adjustments on odf slice example * updated README * Removed unused black tags. * Minor changes in several ray_traced experiments. * Improved multiplatform compatibility of ray_traced_6.0.py. Changed illumination model. * fixed scaling * Fixed merge. * added odf actor implementation * adjusted scaling * Added ray_traced_7.0.py which includes an argument parser. * Added DIPY's ODF slicer python script with argument parser for profiling tool. * Minor changes to ray_traced_7.0.py * Renamed experimental folder. * Changed basis to Tournier's. * reorganized files * Added folders for Descoteaux and Tournier basis. * Updated ray_traced scripts to use spherical harmonics basis. * Added ray_traced_6.5.py to debug performance issues. * added degree param * adjusted the degree setting * Changed first uniform. * Added ray_traced_3.5.py to take single ODF screenshot. * added tests * adjustments on tests and parameter validation * Added Min-Max Normalization function. * Added composed eval sh. * Moved newton_bisection.frag to root_finding folder. * reorganized and refactored odf actor * Re-added newton_bisection.frag to rt_odfs. * Fixed uniform and flats data type. Added numCoeffs param to rayGlyphInteresctions function. * Moved dipy_slicer.py script to personal repo. Renamed as odf_slicer_cli.py * Minor fix on uncertainty cone actor. * Replaced SH_DEGREE with shDegree in rayGlyphIntersections function. * Added extra arguments to rayGlyphIntersections function. * Renamed variables in rayGlyphIntersections finction. * Added new eval_sh.frag. * Added dynamic evalSH function. * Refactored eval_sh_x functions. * Refactored getInvVandermonde function. * Removed unnecessary eval_sh.frag file. * added odf actor implementation * adjusted scaling * reorganized files * added degree param * adjusted the degree setting * added tests * adjustments on tests and parameter validation * reorganized and refactored odf actor * added odf actor implementation * adjusted scaling * reorganized files * added degree param * adjusted the degree setting * added tests * adjustments on tests and parameter validation * reorganized and refactored odf actor * added odf actor implementation * adjusted scaling * reorganized files * added degree param * adjusted the degree setting * added tests * adjustments on tests and parameter validation * reorganized and refactored odf actor * adjusted odf actor and added example * adjustments on variables name and handle degree with uniform * made suggested changes * adjusted odf actor test * fixed format * made adjustments to the format * fixed format * fixed codespell and docs ci's --------- Co-authored-by: Javier Guaje <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to calculate predominant directions within the glyphs and use them for coloring.