Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to improve performance of setEnvVariables() (37! tccd uses 3% CPU continuously) #362

Closed
wants to merge 2 commits into from
Closed

Proposal to improve performance of setEnvVariables() (37! tccd uses 3% CPU continuously) #362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a91b7c9
Improving setEnvVariables() performance (1): Cache results
brunoais Feb 22, 2024
1603a2d
Improving setEnvVariables() performance (2): No need to list all proc…
brunoais Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions src/common/classes/XDisplayRefreshRateController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import * as fs from "fs";
export class XDisplayRefreshRateController {
private displayName: string;
private isX11: boolean;
private dataIsFresh: boolean;
private displayEnvVariable: string;
private xAuthorityFile: string;
public XDisplayRefreshRateController() {
Expand All @@ -31,10 +32,22 @@ export class XDisplayRefreshRateController {
}

private setEnvVariables(): void {
if(this.dataIsFresh){
return;
}
const output = child_process
.execSync(
`ps -u $(id -u) -o pid= | xargs -I{} cat /proc/{}/environ 2>/dev/null | tr '\\0' '\\n'`
)
.execSync(`
ps -u $(id -u) -o pid= | \
tail --lines 20 | \
xargs -I{} cat /proc/{}/environ 2>/dev/null | \
tr '\\0' '\\n' | \
awk '
/DISPLAY=/ && !countDisplay {print; countDisplay++}
/XAUTHORITY=/ && !countXAuthority {print; countXAuthority++}
/XDG_SESSION_TYPE=/ && !countSessionType {print; countSessionType++}
{if (countDisplay && countXAuthority && countSessionType) exit}
'
`)
.toString();

const displayMatch = output.match(/^DISPLAY=(.*)$/m);
Expand Down Expand Up @@ -66,6 +79,9 @@ export class XDisplayRefreshRateController {
: sessionType === "wayland"
? false
: undefined;

this.dataIsFresh = true;
setTimeout(() => this.dataIsFresh = false, 60_000)
}

public getIsX11(): boolean {
Expand Down