Version: Change naming mechanism for editor #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffreyKarnbach
force-pushed
the
gk/291-version-view-editor-names-are-not-human-readable
branch
from
c19062d to
5e1b3db
Compare
|
Comment on lines
+69
to
+76
| String displayName = name; | ||
| if (name == null) { | ||
| if (firstName != null && lastName != null) { | ||
| displayName = firstName + " " + lastName; | ||
| } else { | ||
| displayName = email; | ||
| } | ||
| } |
There was a problem hiding this comment.
Checking if name == null will never be true, since in this case getClaimValue("name").toString() would throw an exception. I would first check (null safe) if name exists. If yes, use it as displayName. If no, check for givenName and family_name...
|
There should also be a plan on how to handle this retroactively, since the editor names for older dmps are just unreadable hashes (at least for TU Wien). Check with TU Graz and Med Uni Graz on how to proceed, if they all have the same problem, i would set old editor names to null, sicne seeing nothing is better than the users seeing random hashes with no visible meaning behind it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix
What does this PR do?
Add new method to security service with claims on JWT to use correct display name for editor in the version view.
closes GH-291