Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Section: Add Commit Message section for guidance #301

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

andresTabiTuwien
Copy link
Contributor

@andresTabiTuwien andresTabiTuwien commented Dec 10, 2024

…sages.

Description

Add a commit message section to the CONTRIBUTING file to provide guidance.

What does this PR do?

Breaking changes

Code review focus

Dependencies

Checks

  • Tested with Oracle/PostgreSQL
  • Export updated
  • Documentation added
  • Tests added
  • E2e tests created
  • Successfully ran e2e tests before merge

closes GH-

@andresTabiTuwien andresTabiTuwien force-pushed the at/Modification-Commits-Description branch from c413c84 to 84b5295 Compare December 10, 2024 09:41
@andresTabiTuwien andresTabiTuwien changed the title Commit Section: Add Commit Message section for guidance in commit mes… Commit Section: Add Commit Message section for guidance Dec 10, 2024
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@ValentinFutterer
Copy link
Collaborator

Looks good, after you have adressed the small things mentioned above we can merge 👍

@andresTabiTuwien andresTabiTuwien force-pushed the at/Modification-Commits-Description branch from 84b5295 to 2fc9039 Compare December 10, 2024 10:25
@andresTabiTuwien andresTabiTuwien marked this pull request as ready for review December 10, 2024 14:27
Copy link
Collaborator

@ValentinFutterer ValentinFutterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, docs are always good to have

@ValentinFutterer ValentinFutterer merged commit a3f286c into next Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants