Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add create DmpDO method and refactor #166

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

rekt-hard
Copy link
Collaborator

@rekt-hard rekt-hard commented Feb 29, 2024

Description

Bugfix

What does this PR do?

Add and use method to create a new DMP for tests.

In a future refactor, all tests should be updated to create a new DMP specifically for the test case. Relying on a certain DMP to be present and modifying the same DMP in several test cases might lead to unforeseen issues.

Breaking changes

Code review focus

Dependencies

Checks

  • Tested with Oracle/PostgreSQL
  • Export updated
  • Documentation added
  • Tests added
  • E2e tests created
  • Successfully ran e2e tests before merge

closes GH-

Copy link
Collaborator

@ValentinFutterer ValentinFutterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
60.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@rekt-hard rekt-hard merged commit 0b9aa7d into next Mar 4, 2024
1 of 2 checks passed
@rekt-hard rekt-hard deleted the update-tests branch April 2, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants