Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export: Made license in publication table a hyperlink #151

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Export: Made license in publication table a hyperlink #151

merged 1 commit into from
Feb 14, 2024

Conversation

ValentinFutterer
Copy link
Collaborator

Description

Feature

What does this PR do?

Makes license acronyms in publication table a hyperlink.

Checks

  • Tested with Oracle/PostgreSQL
  • Export updated
  • Documentation added
  • Tests added
  • E2e tests created
  • Successfully ran e2e tests before merge

closes GH-96

@ValentinFutterer ValentinFutterer added the new feature New feature or request label Jan 30, 2024
rekt-hard
rekt-hard reviewed Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@rekt-hard rekt-hard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the link works well.

Just a formatting issue. Please ensure the font of the text is the same as before.
Maybe also underline it, to signal a hyperlink. Wdyt?

Before:
image

After:
image

@ValentinFutterer
Copy link
Collaborator Author

I have now changed it, so that the formatting is being kept the same. I have also revised the method of replacing the run with a hyperlinkrun - now any run can be replaced, even if it sits between two other runs.

@ValentinFutterer ValentinFutterer force-pushed the vf/96-add-URL-information-of-licenses-to-template-export branch from b8fe874 to dc0e24a Compare February 5, 2024 08:50
@ValentinFutterer ValentinFutterer force-pushed the vf/96-add-URL-information-of-licenses-to-template-export branch from dc0e24a to fb932a5 Compare February 14, 2024 15:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@rekt-hard rekt-hard merged commit ed284a3 into next Feb 14, 2024
1 of 2 checks passed
@rekt-hard rekt-hard deleted the vf/96-add-URL-information-of-licenses-to-template-export branch April 2, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekt-hard rekt-hard rekt-hard approved these changes

Assignees
No one assigned
Labels
new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add URL information of licenses to template export
2 participants
@ValentinFutterer @rekt-hard