Export: Delete delete/reused datasets tables when empty #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinFutterer
assigned rekt-hard and ValentinFutterer and unassigned rekt-hard and ValentinFutterer
ValentinFutterer
force-pushed
the
vf/132-remove-empty-tables-in-export-if-no-data-is-present
branch
from
ba1a72b to
041e04b
Compare
rekt-hard
reviewed
Jan 19, 2024
src/main/java/at/ac/tuwien/damap/conversion/AbstractTemplateExportScienceEuropeComponents.java
Outdated
Show resolved
Hide resolved
src/main/java/at/ac/tuwien/damap/conversion/AbstractTemplateExportScienceEuropeComponents.java
Outdated
Show resolved
Hide resolved
src/main/java/at/ac/tuwien/damap/conversion/AbstractTemplateExportScienceEuropeComponents.java
Outdated
Show resolved
Hide resolved
src/main/java/at/ac/tuwien/damap/conversion/AbstractTemplateExportScienceEuropeComponents.java
Outdated
Show resolved
Hide resolved
ValentinFutterer
force-pushed
the
vf/132-remove-empty-tables-in-export-if-no-data-is-present
branch
from
041e04b to
e3a2d4e
Compare
rekt-hard
reviewed
Jan 26, 2024
src/main/java/at/ac/tuwien/damap/conversion/AbstractTemplateExportFunctions.java
Outdated
Show resolved
Hide resolved
ValentinFutterer
force-pushed
the
vf/132-remove-empty-tables-in-export-if-no-data-is-present
branch
from
e3a2d4e to
a90f825
Compare
|
rekt-hard
deleted the
vf/132-remove-empty-tables-in-export-if-no-data-is-present
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix
What does this PR do?
The reused dataset and dataset delete tables are now removed when there is no data for them.
Checks
closes GH-132