103 orcid contributor affiliation selected randomly #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
...st/java/at/ac/tuwien/damap/conversion/AbstractTemplateExportScienceEuropeComponentsTest.java
Show resolved
Hide resolved
rekt-hard
force-pushed
the
103-orcid-contributor-affiliation-selected-randomly
branch
2 times, most recently
from
96c0a7d to
5c3d324
Compare
ValentinFutterer
requested changes
Jan 30, 2024
src/main/java/at/ac/tuwien/damap/rest/persons/orcid/ORCIDMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/at/ac/tuwien/damap/rest/dmp/service/DmpService.java
Outdated
Show resolved
Hide resolved
rekt-hard
force-pushed
the
103-orcid-contributor-affiliation-selected-randomly
branch
from
5c3d324 to
66590bb
Compare
|
...st/java/at/ac/tuwien/damap/conversion/AbstractTemplateExportScienceEuropeComponentsTest.java
Show resolved
Hide resolved
rekt-hard
force-pushed
the
103-orcid-contributor-affiliation-selected-randomly
branch
from
66590bb to
304ffba
Compare
ValentinFutterer
approved these changes
Mar 4, 2024
rekt-hard
deleted the
103-orcid-contributor-affiliation-selected-randomly
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
Information for new contributors with ORCID identifier set will be fetched on DMP create/update. Affiliation will be selected to be current, with the earliest start date.
Since the information for email and the affiliations is scattered around the person attribute and the summary attribute, the whole ORCID record will be fetched. Required classes have been specified.
The ORCID test record resource is from the public ORCID API and the name has been modified.
Breaking changes
ORCID service will retrieve information from the
/<orcid>/recordendpoint.Code review focus
Dependencies
Checks
closes #103