Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change terminology Sleeping to Archived #221

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Change terminology Sleeping to Archived #221

merged 3 commits into from
Aug 7, 2024

Conversation

avinassh
Copy link
Member

@avinassh avinassh commented Aug 6, 2024

Some users are getting confused with the terminology Sleeping as we also have cold starts. This patch changes the word to Archived. This also changes the word Wake up to Unarchive

CLI PR: tursodatabase/turso-cli#902

API: https://github.com/tursodatabase/turso/pull/1998

@avinassh avinassh requested a review from notrab August 6, 2024 08:16
@@ -2232,7 +2232,7 @@
},
"sleeping": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athoscouto @avinassh do we plan to update the API too? Otherwise it’s just as confusing if we don’t.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not made changes to the API to keep backward compatibility.

I will send a follow up patch and update the API spec and replace sleeping with archived. On the API server, I will send both the fields. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending both fields sounds good to me. We can then update the docs to use archived and never speak of sleeping again 😂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is sleeping

@avinassh
Copy link
Member Author

avinassh commented Aug 6, 2024

The server now sends archived field (https://github.com/tursodatabase/turso/pull/1999). So I have updated the Open API spec

@avinassh avinassh requested a review from notrab August 6, 2024 14:37
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to rename this path? Also, we should add a redirect for the old pages to the new ones. I think mint.json has an example of this, on my phone though so unable to test locally.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just renamed to keep it consistent. However, you are right about redirects and I missed that. I have added redirects now. However, if you want to keep the old path names, then I can revert those changes.

I am having some issue with node locally and not able to run it. I will report back if I get it to working.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good!

@avinassh avinassh merged commit 45cf7dc into main Aug 7, 2024
@avinassh avinassh deleted the sleeping branch August 7, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants