-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change terminology Sleeping
to Archived
#221
Conversation
api-reference/openapi.json
Outdated
@@ -2232,7 +2232,7 @@ | |||
}, | |||
"sleeping": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@athoscouto @avinassh do we plan to update the API too? Otherwise it’s just as confusing if we don’t.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not made changes to the API to keep backward compatibility.
I will send a follow up patch and update the API spec and replace sleeping
with archived
. On the API server, I will send both the fields. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sending both fields sounds good to me. We can then update the docs to use archived and never speak of sleeping again 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is sleeping
The server now sends |
cli/db/wakeup.mdx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to rename this path? Also, we should add a redirect for the old pages to the new ones. I think mint.json has an example of this, on my phone though so unable to test locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just renamed to keep it consistent. However, you are right about redirects and I missed that. I have added redirects now. However, if you want to keep the old path names, then I can revert those changes.
I am having some issue with node locally and not able to run it. I will report back if I get it to working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good!
Some users are getting confused with the terminology
Sleeping
as we also have cold starts. This patch changes the word toArchived
. This also changes the wordWake up
toUnarchive
CLI PR: tursodatabase/turso-cli#902
API: https://github.com/tursodatabase/turso/pull/1998