Will Chen and Will Weston PR #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Landing page
Webvcr testing
Gem: Add gems Versioning: Create api/v1 directories and moved userscontroller into it Create: Moviescontroller with appropriate modules Create: Movie model Add: association for has_may viewing parties to user model Create: ViewingParty model Create: MovieDbService to be used as a service later on for api calls Create: User Dashboard rough wireframe mock Replace: routes ordered for api versioning Add: movies to schema Add: viewing_parties to schema Migration: movies Migration: ViewingParties FactoryBot: Movie FactoryBot: viewing_party Spec: Movie model spec created Spec: viewing party model spec created
User Dashboard
Spec: MovieDBService.new test pass Add: movie_details fixtures .json Spec: User Show Page - failed deleted code FactoryBot: add associations FactoryBot: add email and name faker FactoryBot: add Faker for movie Add: spec_helper VCR and webmock Add: rails_helper VCR configure and factorybot Migration: viewing_parties boolean is_host Schema: t.boolean is_host Routes: delete user only and replace with just user credentials: added secret keys Replace: user show page to include with_index Replace: httparty with faraday Create: Review Poro Create: Movie Poro Create: Cast Poro Add: scope for hosted_by is true Replace: has_many viewing parties and users, through :viewing_parties Create: Movie Facade Delete: users controller nested through api/v1 Add: @movie_details in show action of Users Controllers Replace: movies_controller show action
Movies user
Spec: MovieDBService spec passing w/ VCR Create: Poro Review spec Create: Poro Movie spec Create: Poro Cast spec Add: User Show page spec - currently failing Remove: VCR Config from spec_helper Replace: base URL and response in movie_db_service
Spec: User show page initial dashboard test - pass Add: record: new episodes for VCR in rails helper Delete: @movie_details.image for now supposed to be poster_path Replace: connection -> conn in Movie_db_service Add: poster path to attr_reader in Movie Poro Add: strict load true for Application record Replace: instance methods to class methods for movie_facade Add: includes viewing parties for User show action
Change movies controller index. Show still needs adjustment Refactor users controller for Rubocop Add movie poro new to movies method Add results to parsed response in top rated and search for moviedbservice Add table and return button to movies index view User discover view: Change button to manual form with hidden tag to modify top rated params Movies Index Spec: Add file for base testing. Could use more thurough expects 2 cassettes created for movies index spec
Spec: Add tests to MovieDbService Spec - all pass Spec: Create POROs Review spec - pass Spec: Create POROs Movie spec - pass Spec: Create POROs Cast spec - pass Spec: Create Model ViewingParty spec - pass Spec: Create Model User spec - pass Spec: Create Model Movie spec - pass Spec: Add user show page tests - all pass Spec: MovieFacade - pass Spec: ApplicationController spec for invited_guests method - pass Migration: poster_paths so save to objects as well Schema: Updated for poster_path Show: User Show Dash updated - passing Add: Rating to review PORO Delete: image method from Movie PORO Add: guests method to ViewingParty Add: Associations for User Model Add: serialize genres to Movie model - pending Add: keys to MovieFacade Add: User includes for show action on UsersController Update: MoviesController show method details -> movie_details to match Add: invited_friends method to ApplicationController for inheritance
Movies User Branch - Will C
Dashboard 1.1
Viewing Parties Controller: Change new and create to correct for params Viewing Parties New View: Change fields to match schema. Still needs time_field and invitees adjustment Routes: Add create viewing party post Seeds: Add Allan Migration: Add duration as a column to viewing_party
New viewing party
Spec: User Movie show page - pass Add: classifier for movie search form Add: ViewingParty Movie Details from other branch Add: classifier for movie results on movies/index html.erb Add: Reviews to Poro Movie Add: .first(10) to cast on MovieFacade Add: Movie_Service to show action on Movies Controller - might have to replace
…nto DetailsUpdated Pulling down new PR from main
Movie Details
Cassetttes: Add 8 for testing Movies Controller: Add sad path Movies Facade: Remove sad path Views layouts application: Add flash alert for sad path Movie Facade Spec: Rename to include spec Movies Facade Spec: Add top rated and query tests Movies Index Spec: Add and refactor happy and sad path tests
Cassettes: 6 created for testing Users controller: Remove unnecessary line Movie db service: Remove whitespace Users Show View: Add Discover button Seeds: Add Chen to seeds Movie Facade Spec: Add initialize test User Show Spec: Remove untested lines User Show Spec: Add discover button test Movie db service spec: Add sad path test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.