Zion Mekonnen #613
Open
Zion Mekonnen #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memcmahon
reviewed
Dec 18, 2024
| :engine, | ||
| :plate_type, | ||
| :antique, | ||
| :register_date |
There was a problem hiding this comment.
Make sure you name your attr_readers with the same name as your instance variable that it is reading. In this case, it should be :registration_date
| expect(cruz.registration_date).to eq(nil) | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
You want to add tests for any methods that you create. It looks like we are missing tests for update_registration_date and update_plate_type
| expect(registrant_2.license_data).to eq({:written=>false, :license=>false, :renewed=>false}) | ||
| end | ||
|
|
||
| it "returns if permit is earned" do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.