Joseph Bloom #603
Joseph Bloom #603
Conversation
git push git status
Iteration 1 branch 1
Iteration2branch2
Iteration3branch3
iteration 3 looking good. new dmv_facilities class and accompanying s…
iteration 4 begins
Iteration4branch4
Merge pull request #6 from Jsphbloom/iteration4branch4
spec tests looking nice on dmv_facilities_spec
| require './lib/dmv_data_service' | ||
|
|
||
|
|
||
| class DmvFacilities |
There was a problem hiding this comment.
I think it might make more sense to call this class DMVFactory to match the Vehicle Factory naming convention
|
|
||
| def administer_written_test(registrant) | ||
| if @services.include?("Written Test") && registrant.permit? == true | ||
| registrant.license_data[:written] = true |
There was a problem hiding this comment.
This definitely works, but it would be a little better if there was a method on the registrant class that managed this change. It could either be explicitly exposing license_data as an attr_writer or attr_accessor, or you could create a method to earn_written_license that would change the value from inside the registrant.
There was a problem hiding this comment.
That makes sense! i thought it was a little weird that I was handling this from facility.
| @address = address | ||
| @phone = phone | ||
| def initialize(facility_details) | ||
| @name = facility_details[:name] || facility_details[:dmv_office] || facility_details[:office_name] |
| describe '#register vehicle' do | ||
| it 'can register a vehicle' do | ||
| @facility.register_vehicle(@cruz) | ||
| expect(@facility.registered_vehicles).to eq([@cruz]) |
There was a problem hiding this comment.
You also want to make sure that the registration date is set when this method is called!
No description provided.