Beverly Green - the_dmv #598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests passing through iteration 1 requirements
…y_class Functional Vehicle Registration
Written test rspec tests all passing
Drivers license feature
Rspec tests for vehicle factory passing
Dmv state facility datasets
memcmahon
reviewed
Dec 18, 2024
| @@ -0,0 +1,19 @@ | |||
| class DMVFacilities | |||
There was a problem hiding this comment.
I think it might make more sense to call this class DMVFactory to match the Vehicle Factory naming convention
| @permit = true | ||
| end | ||
|
|
||
| def change_license_data(key) |
There was a problem hiding this comment.
Love this helper method! Just make sure that you are writing tests for any methods that you add 😉
| def register_vehicle(vehicle) | ||
|
|
||
| if @services.include?('Vehicle Registration') | ||
| @registered_vehicles << vehicle |
There was a problem hiding this comment.
When a vehicle is registered, you probably also want to call the registration method on the vehicle so that the plate type is set and the registration date is updated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.