-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Team LPR (Logan, Patrick, Rig) - Futbol Project Submission #1153
Open
ontruster74
wants to merge
84
commits into
turingschool-examples:main
Choose a base branch
from
ontruster74:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iteration 1 - Readme and discussion questions
File I/O is setup and ready for methods to be built around it.
…f games by season works!
…f games by season works!
Percentages
…tests. I can't get the tests to pass. I am getting the return value I want in pry but not with my tests
update tests and class file for stattracker for #most/least_accurate_…
Coach stats
Variable Names and Dummy CSV Removal
…roject, also a test for game_team_season was added
Season stats final
…gains the spec harness yet
Team stats patrick
Iteration 4 Methods - Part 1
added the team_info and average_win_percentage with correponding tests
Rearrange Spec File Describe Blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is our final submission for the Futbol group project. We completed iterations 1-3, and most of Iteration 4. Our StatTracker class and instance methods are all spec compliant, and are fully compatible with the Spec Harness test suite. We also achieved 100% line coverage in SimpleCov, which is installed in the root directory and functions appropriately. Please let us know if we are missing anything important!