WIP #67
Annotations
19 errors and 9 warnings
cargo-test:
src/authentication/authentication_context.rs#L238
mismatched types
|
cargo-test:
src/authentication/authentication_context.rs#L237
missing field `ban_patrol` in initializer of `authentication_context::AuthenticationContext<_>`
|
cargo-test:
src/authentication/authentication_context.rs#L256
this method takes 2 arguments but 1 argument was supplied
|
cargo-test:
src/authentication/authentication_context.rs#L264
this method takes 2 arguments but 1 argument was supplied
|
cargo-test:
src/authentication/authentication_context.rs#L271
this method takes 2 arguments but 1 argument was supplied
|
cargo-test:
src/authentication/authentication_context.rs#L285
this method takes 2 arguments but 1 argument was supplied
|
cargo-test:
src/authentication/authentication_context.rs#L297
this method takes 2 arguments but 1 argument was supplied
|
cargo-test:
src/authentication/authentication_context.rs#L310
this method takes 2 arguments but 1 argument was supplied
|
cargo-test:
src/authentication/authentication_context.rs#L320
this method takes 2 arguments but 1 argument was supplied
|
cargo-test:
src/authentication/authentication_context.rs#L338
this method takes 2 arguments but 1 argument was supplied
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/authentication/authentication_service.rs#L142
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/authentication/authentication_service.rs:142:55
|
142 | let response = match context.authenticate_request(&peer, &buffer).await {
| ^^^^^ help: change this to: `peer`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
|
unneeded `return` statement:
src/authentication/authentication_service.rs#L147
error: unneeded `return` statement
--> src/authentication/authentication_service.rs:147:5
|
147 | return response;
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `-D clippy::needless-return` implied by `-D warnings`
help: remove `return`
|
147 - return response;
147 + response
|
|
field `authentication_attempts` is never read:
src/authentication/ban_patrol.rs#L22
error: field `authentication_attempts` is never read
--> src/authentication/ban_patrol.rs:22:5
|
20 | pub struct BanPatrol {
| --------- field in this struct
21 | penalties: HashMap<String, (usize, Instant)>,
22 | authentication_attempts: usize,
| ^^^^^^^^^^^^^^^^^^^^^^^
|
constant `BAN_LEVELS` is never used:
src/authentication/ban_patrol.rs#L18
error: constant `BAN_LEVELS` is never used
--> src/authentication/ban_patrol.rs:18:7
|
18 | const BAN_LEVELS: usize = 10;
| ^^^^^^^^^^
|
variant `ExceededAllowedAttempts` is never constructed:
src/authentication/authentication_errors.rs#L38
error: variant `ExceededAllowedAttempts` is never constructed
--> src/authentication/authentication_errors.rs:38:5
|
20 | pub enum AuthenticationError {
| ------------------- variant in this enum
...
38 | ExceededAllowedAttempts(Instant),
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `AuthenticationError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `-D dead-code` implied by `-D warnings`
|
unused variable: `duration`:
src/authentication/ban_patrol.rs#L55
error: unused variable: `duration`
--> src/authentication/ban_patrol.rs:55:9
|
55 | duration: &mut Instant,
| ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_duration`
|
unused variable: `attemps`:
src/authentication/ban_patrol.rs#L54
error: unused variable: `attemps`
--> src/authentication/ban_patrol.rs:54:9
|
54 | attemps: &mut usize,
| ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_attemps`
|
= note: `-D unused-variables` implied by `-D warnings`
|
unused import: `tokio::sync::Mutex`:
src/authentication/authentication_context.rs#L27
error: unused import: `tokio::sync::Mutex`
--> src/authentication/authentication_context.rs:27:5
|
27 | use tokio::sync::Mutex;
| ^^^^^^^^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
|
cargo-clippy
Clippy had exited with the 101 exit code
|
cargo-deny
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
cargo-test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
cargo-test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
cargo-test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
cargo-test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
cargo-test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
cargo-test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
cargo-clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
cargo-clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|