fix test for new approx count #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushrax
approved these changes
Apr 18, 2024
morgangallant
pushed a commit
that referenced
this pull request
Apr 23, 2024
morgangallant
added a commit
that referenced
this pull request
Jun 5, 2024
* lint: format using Black * feat: add AsyncBackend - use httpx instead of requests - allow passing httpx clients (sync and/or async) * fix: user-agent header typo * upsert: add distance_metric on upsert * Bump version 0.1.8 * remove usage of implicit And (#19) * support new filter syntax (#20) * update version * fix test for new approx count (#21) * wip merge Signed-off-by: Morgan Gallant <[email protected]> * fix warnings Signed-off-by: Morgan Gallant <[email protected]> * remove "distances" from upsert json Signed-off-by: Morgan Gallant <[email protected]> * fix merge issues Signed-off-by: Morgan Gallant <[email protected]> --------- Signed-off-by: Morgan Gallant <[email protected]> Co-authored-by: Sourabh Mundhra <[email protected]> Co-authored-by: Simon Eskildsen <[email protected]> Co-authored-by: Justin Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pushrax our new approx count is slightly more accurate, these tests apparantly rely on their ordering...