Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py UX responses and module checks with helpful messaging #277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bgorlick
Copy link

Small update to setup.py. I've modified the user experience messaging to make life a bit easier for new users diving in. Smoother module dependency checks now (none requiring anything except base python in case they don't have setuptools or anything) with some added helpful verbage. Example is now if you accidentally forget arguments, it'll nudge towards the README while suggesting the proper setup install command. If you don't have certain modules, it'll tell you which are missing. The previous one if you didn't have torch just exited and you saw a missing torch module error.

@turboderp
Copy link
Owner

This would need a bit of testing to make sure it works with the build/release workflows. I'll look at it when I bump to 0.0.12

@Ph0rk0z
Copy link

Ph0rk0z commented Jan 20, 2024

So will this fail in conda when I do python setup.py install because I do not add "user".

@turboderp
Copy link
Owner

The --user argument has been useful for me, but I think it depends how your environment is set up. Sadly there are many ways to go about it, and in my current setup --user actually fails because, I think because I'm not using Conda?

There are also a lot of deprecation warnings so invoking the setup.py script directly has to stop at some point anyway. I'm leaning towards pip install . as the new standard approach. It's been working for me recently both on Linux (at least with a Python venv) and Windows.

@Ph0rk0z
Copy link

Ph0rk0z commented Jan 20, 2024

You're right it is the future. llama.cpp python and others use that now. Often times I have to edit setup files anyway because many push hard versioned deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants