Merge pull request #7 from tunapanda/dep-handling

Gracefully handle missing dependencies
tunapanda · Jan 16, 2017 · 8df6e15 · 8df6e15
2 parents e0be841 + 4a6849a
commit 8df6e15
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/dist/js/h5p-standalone-main.js b/dist/js/h5p-standalone-main.js
@@ -9641,6 +9641,10 @@ var _slicedToArray = (function () { function sliceIterator(arr, i) { var _arr =
         var dependency = dependencies.find(function (dept) {
           return dept.name === dependencyName;
         });
+        if (typeof dependency === "undefined") {
+          console.warn("Skipping unmet dependency " + dependencyName);
+          return;
+        }
         Array.prototype.push.apply(styles, dependency.styles);
         Array.prototype.push.apply(scripts, dependency.scripts);
       });

diff --git a/dist/js/h5p-standalone-main.min.js b/dist/js/h5p-standalone-main.min.js
diff --git a/src/js/h5pintegration.es6 b/src/js/h5pintegration.es6
@@ -121,6 +121,10 @@
       let dependency = dependencies.find(function (dept) {
         return dept.name === dependencyName;
       });
+      if (typeof dependency === "undefined") {
+        console.warn("Skipping unmet dependency " + dependencyName);
+        return;
+      }
       Array.prototype.push.apply(styles, dependency.styles);
       Array.prototype.push.apply(scripts, dependency.scripts);
     });

diff --git a/src/js/h5pintegration.js b/src/js/h5pintegration.js
@@ -145,6 +145,10 @@ var _slicedToArray = (function () { function sliceIterator(arr, i) { var _arr =
         var dependency = dependencies.find(function (dept) {
           return dept.name === dependencyName;
         });
+        if (typeof dependency === "undefined") {
+          console.warn("Skipping unmet dependency " + dependencyName);
+          return;
+        }
         Array.prototype.push.apply(styles, dependency.styles);
         Array.prototype.push.apply(scripts, dependency.scripts);
       });