Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test files to track LaTeX2e 2024-11-01 changes #979

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

muzimuzhi
Copy link
Contributor

Track LaTeX2e 2024-11-01 changes:

  • Previously provided by hyperref, \theH<counter> and \@currentHref are now defined/updated directly by LaTeX. Hence value of \@currentHref, the destination name, is seen in the 4th value of the 5-tuple written by \label.
  • \theHequation now starts with its actual parent counter, not the unconditional \theHsection when it was defined in hyperref. Hence the changes in destination names for equation counters.

BTW the build job may need some adaption to pass also in (general) fork repositories. It now always fails (e.g., this run) in tag-free forks, as it runs the command git describe --tags which requires existence of tag(s).

- name: Build release zip
run: |
version=$(git describe --tags)
echo "Current git revision: $version"
python3 utils/create_release.py --version $version

Track LaTeX2e 2024-11-01 changes:

- Previously provided by `hyperref`, `\theH<counter>` and
  `\@currentHref` are now defined/updated directly by LaTeX. Hence
  value of `\@currentHref`, the destination name, is seen in the 4th
  value of the 5-tuple written by `\label`.
- `\theHequation` now starts with its actual parent counter, not the
  unconditional `\theHsection` when it was defined in `hyperref`.
  Hence the changes in destination names for `equation` counters.
@Harry-Chen Harry-Chen merged commit 415d2d7 into tuna:master Nov 12, 2024
6 checks passed
@Harry-Chen
Copy link
Member

Thanks! I will try to fix the CI config to make it more friendly.

@muzimuzhi muzimuzhi deleted the update-testfiles branch November 12, 2024 12:51
@Harry-Chen
Copy link
Member

The CI failure in forks should be fixed in bd04810

@muzimuzhi
Copy link
Contributor Author

muzimuzhi commented Nov 12, 2024

thanks!

And nice git describe option --always which gives fallback results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants