Fixed poll and comment bug

tuhinexe · Apr 7, 2023 · 6cda5d6 · 6cda5d6
1 parent c90571a
commit 6cda5d6
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 2 deletions.
diff --git a/backend/api/commentAPI.js b/backend/api/commentAPI.js
@@ -19,7 +19,7 @@ const addComment = async (commentDetails, postId) => {
         throw new Error(error);
       });
   } catch (err) {
-    console.log(err);
+    throw new Error(err);
   }
 };
 

diff --git a/backend/controllers/commentController.js b/backend/controllers/commentController.js
@@ -7,6 +7,12 @@ const addCommentController= async (req,res) =>{
       commentor: req.user._id
     }
     const postId = req.params.postId
+
+    if(commentDetails.content.trim() === ""){
+      req.flash("error","cannot add empty comment")
+      res.redirect(`/post/${postId}`)
+      return
+    }
 
     try{
       await commentAPI.addComment(commentDetails,postId)

diff --git a/backend/controllers/pollController.js b/backend/controllers/pollController.js
@@ -24,6 +24,11 @@ const createPollsController = async (req, res) => {
     const id = req.user._id;
     const title = req.body.title;
     const [option1, option2, option3, option4] = req.body.option;
+    if(title.trim() === "" || option1.trim() === "" || option2.trim() === "" || option3.trim() === "" || option4.trim() === ""){
+        req.flash("error", "can't create poll with empty fields");
+        res.redirect("/");
+        return;
+    }
     const newPoll = new pollsModel({
         creatorId: id,
         content: title,

diff --git a/backend/controllers/postController.js b/backend/controllers/postController.js
@@ -101,7 +101,7 @@ const getSinglePostRender = async (req, res) => {
       pagename: "comment",
       profilePic: req.user.profilePic_url,
     };
-    res.render("post", { pageInfo: pageInfo, post: post, comments: comments });
+    res.render("post", { pageInfo: pageInfo, post: post, comments: comments, messages: req.flash() });
   } catch (err) {
     res.redirect("/");
   }

diff --git a/backend/views/post.ejs b/backend/views/post.ejs
@@ -90,4 +90,9 @@
 </div>
 
 </section>
+
+<% if(messages.error){ %>
+
+    <%- include ('partials/flashModal',{messages: messages}) %>
+<% } %>
 <%- include ('partials/footer') %>