Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up usages of hard coded paths of source conventions #148

Merged

Conversation

tudortimi
Copy link
Owner

No description provided.

tudortimi added 5 commits June 1, 2024 21:21
…ject tree

We use the same interpretation as when producing args files: the `srcDirs` of the source directory set are the directories to include. We still have to take all files in each of these directories, because we don't have a way to track the private headers yet.

The tricky part here is to make this work in a "lazy" way. We can't just call `svSourceSet.getSv().getSrcDirs()` and loop over those directories, because then we would only ever get the default directory (i.e.e "src/main/sv"). We have to map each source directory to `project.files()`, which will then give us all files under that directory. Since we use providers, we are just defining the mapping, but the actual computation is done when the task gets executed.
…oject tree

The same caveats as for private header dirs apply.
@tudortimi tudortimi changed the title Clean up usages of hard coded paths for source conventions Clean up usages of hard coded paths of source conventions Jun 1, 2024
@tudortimi tudortimi merged commit 41a37e5 into master Jun 1, 2024
1 check passed
@tudortimi tudortimi deleted the clean-up-usages-of-hard-coded-paths-for-source-conventions branch June 1, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant