-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
started unifying tracing #65
Open
rschoene
wants to merge
23
commits into
master
Choose a base branch
from
unifytracing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+166
−60
Open
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
fadc867
started unifying tracing
rschoene e522e29
some changes
rschoene dd939a9
try to find out what went wrong here
rschoene 8e045df
turned some things into options
rschoene d4e1d2b
another test
rschoene 744688e
test. works now?
rschoene b35895c
reset workflow
rschoene add7ef6
next try
rschoene e457a99
...
rschoene 0ac014f
:'(
rschoene dfad346
...
rschoene e7fd0f0
...
rschoene 3a716d3
using free functions instead of methods
rschoene 98ea605
Merge remote-tracking branch 'origin/master' into unifytracing
rschoene 9b4cff2
fixes. now we do not call tracing if not defined
rschoene 0946cd2
fixed tracing. Now it finds scorep (if avail) and can compile (even t…
rschoene d659020
VampirTrace should not be used anymore
rschoene 4d372f1
remove mention of VampirTrace
rschoene 7c1c8f8
info on tracing
rschoene 413c4c4
less hip, then runs?
rschoene 136cdd1
Score-P now external as it should be
rschoene 600e017
smaller fixes
rschoene d8a554a
only external interface left
rschoene File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/****************************************************************************** | ||
* FIRESTARTER - A Processor Stress Test Utility | ||
* Copyright (C) 2020-2024 TU Dresden, Center for Information Services and High | ||
* Performance Computing | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/\>. | ||
* | ||
* Contact: [email protected] | ||
*****************************************************************************/ | ||
|
||
#pragma once | ||
|
||
namespace firestarter::tracing { | ||
|
||
class Tracing { | ||
public: | ||
Tracing(); | ||
~Tracing(); | ||
|
||
inline void regionBegin(const char* const region_name); | ||
inline void regionEnd(const char* const region_name); | ||
}; | ||
|
||
} // firestarter::tracing |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
/****************************************************************************** | ||
* FIRESTARTER - A Processor Stress Test Utility | ||
* Copyright (C) 2020-2024 TU Dresden, Center for Information Services and High | ||
* Performance Computing | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/\>. | ||
* | ||
* Contact: [email protected] | ||
*****************************************************************************/ | ||
|
||
#include <firestarter/Tracing/Tracing.hpp> | ||
|
||
#include <adiak.hpp> | ||
#include <caliper/cali.h> | ||
|
||
using namespace firestarter::tracing; | ||
|
||
Tracing::Tracing(){} | ||
Tracing::~Tracing(){} | ||
|
||
inline void Tracing::regionBegin(const char* const region_name) { | ||
CALI_MARK_BEGIN(region_name); | ||
} | ||
|
||
inline void Tracing::regionEnd(const char* const region_name) { | ||
CALI_MARK_END(region_name); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/****************************************************************************** | ||
* FIRESTARTER - A Processor Stress Test Utility | ||
* Copyright (C) 2020-2024 TU Dresden, Center for Information Services and High | ||
* Performance Computing | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/\>. | ||
* | ||
* Contact: [email protected] | ||
*****************************************************************************/ | ||
|
||
|
||
#include <firestarter/Logging/Log.hpp> | ||
#include <firestarter/Tracing/Tracing.hpp> | ||
|
||
using namespace firestarter::tracing; | ||
|
||
Tracing::Tracing(){} | ||
Tracing::~Tracing(){} | ||
|
||
inline void Tracing::regionBegin(const char* const region_name) { | ||
firestarter::log::trace() << "Start " << region_name; | ||
} | ||
|
||
inline void Tracing::regionEnd(const char* const region_name) { | ||
firestarter::log::trace() << "End " << region_name; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,36 @@ | ||||||||||||||||||||||||||||||
/****************************************************************************** | ||||||||||||||||||||||||||||||
* FIRESTARTER - A Processor Stress Test Utility | ||||||||||||||||||||||||||||||
* Copyright (C) 2020-2024 TU Dresden, Center for Information Services and High | ||||||||||||||||||||||||||||||
* Performance Computing | ||||||||||||||||||||||||||||||
* | ||||||||||||||||||||||||||||||
* This program is free software: you can redistribute it and/or modify | ||||||||||||||||||||||||||||||
* it under the terms of the GNU General Public License as published by | ||||||||||||||||||||||||||||||
* the Free Software Foundation, either version 3 of the License, or | ||||||||||||||||||||||||||||||
* (at your option) any later version. | ||||||||||||||||||||||||||||||
* | ||||||||||||||||||||||||||||||
* This program is distributed in the hope that it will be useful, | ||||||||||||||||||||||||||||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||||||||||||||||||||||||||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||||||||||||||||||||||||||||||
* GNU General Public License for more details. | ||||||||||||||||||||||||||||||
* | ||||||||||||||||||||||||||||||
* You should have received a copy of the GNU General Public License | ||||||||||||||||||||||||||||||
* along with this program. If not, see <http://www.gnu.org/licenses/\>. | ||||||||||||||||||||||||||||||
* | ||||||||||||||||||||||||||||||
* Contact: [email protected] | ||||||||||||||||||||||||||||||
*****************************************************************************/ | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
#include <firestarter/Tracing/Tracing.hpp> | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
using namespace firestarter::tracing; | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
Tracing::Tracing(){} | ||||||||||||||||||||||||||||||
Tracing::~Tracing(){} | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
inline void Tracing::regionBegin(const char* const region_name) { | ||||||||||||||||||||||||||||||
// Do nothing | ||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
inline void Tracing::regionEnd(const char* const region_name) { | ||||||||||||||||||||||||||||||
// Do nothing | ||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
fix warnings |
||||||||||||||||||||||||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
/****************************************************************************** | ||
* FIRESTARTER - A Processor Stress Test Utility | ||
* Copyright (C) 2020-2024 TU Dresden, Center for Information Services and High | ||
* Performance Computing | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/\>. | ||
* | ||
* Contact: [email protected] | ||
*****************************************************************************/ | ||
|
||
#include <scorep/SCOREP_User.h> | ||
|
||
#include <firestarter/Tracing/Tracing.hpp> | ||
|
||
using namespace firestarter::tracing; | ||
|
||
Tracing::Tracing(){} | ||
Tracing::~Tracing(){} | ||
|
||
inline void Tracing::regionBegin(const char* const region_name) { | ||
SCOREP_USER_REGION_BY_NAME_BEGIN(region_name, | ||
SCOREP_USER_REGION_TYPE_COMMON); | ||
} | ||
|
||
inline void Tracing::regionEnd(const char* const region_name) { | ||
SCOREP_USER_REGION_BY_NAME_END(region_name); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/****************************************************************************** | ||
* FIRESTARTER - A Processor Stress Test Utility | ||
* Copyright (C) 2020-2024 TU Dresden, Center for Information Services and High | ||
* Performance Computing | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/\>. | ||
* | ||
* Contact: [email protected] | ||
*****************************************************************************/ | ||
|
||
#include <vt_user.h> | ||
#include <firestarter/Tracing/Tracing.hpp> | ||
|
||
using namespace firestarter::tracing; | ||
|
||
Tracing::Tracing(){} | ||
Tracing::~Tracing(){} | ||
|
||
inline void Tracing::regionBegin(const char* const region_name) { | ||
VT_USER_START(region_name); | ||
} | ||
|
||
inline void Tracing::regionEnd(const char* const region_name) { | ||
VT_USER_END(region_name); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.