## Version 0.2.5

* Default XIRR does not raise an Exception if cashflow is invalid

CHANGE_LOG.md

@@ -1,3 +1,8 @@
+## Version 0.2.5
+
+* Default XIRR does not raise an Exception if cashflow is invalid
+
+
 ## Version 0.2.4
 
 * Cashflow Invalid Messages are now public.

lib/xirr/cashflow.rb

@@ -16,7 +16,7 @@ def initialize(*args)
       self.flatten!
     end
 
-    # Check if Cashflow is invalid and raises ArgumentError
+    # Check if Cashflow is invalid
     # @return [Boolean]
     def invalid?
       positives.empty? || negatives.empty?
@@ -50,7 +50,7 @@ def irr_guess
     # @param method [Symbol]
     # @return [Float]
     # Finds the XIRR according to the method provided. Default to Bisection
-    def xirr(guess = nil, method = Xirr.config.default_method)
+    def xirr_with_exception(guess = nil, method = Xirr.config.default_method)
       if valid?
         choose_(method).send :xirr, guess
       else
@@ -62,11 +62,11 @@ def xirr(guess = nil, method = Xirr.config.default_method)
     # @param guess [Float]
     # @param method [Symbol]
     # @return [Float]
-    def xirr_no_exception(guess = nil, method = Xirr.config.default_method)
+    def xirr(guess = nil, method = Xirr.config.default_method)
       if invalid?
         BigDecimal.new(0, Xirr::PRECISION)
       else
-        xirr(guess, method)
+        xirr_with_exception(guess, method)
       end
     end
 

lib/xirr/version.rb

@@ -1,4 +1,4 @@
 module Xirr
   # Version of the Gem
-  VERSION = "0.2.4"
+  VERSION = "0.2.5"
 end

test/test_cashflow.rb

@@ -14,10 +14,14 @@
       assert_raises(ArgumentError) { @cf.xirr(nil, :no_method) }
     end
 
-    it 'has an Internal Rate of Return on Bisection Method' do
+    it 'has an Internal Rate of Return on default Method' do
       assert_equal '0.225683'.to_f, @cf.xirr
     end
 
+    it 'has an Internal Rate of Return on default Method' do
+      assert_equal '0.225683'.to_f, @cf.xirr(nil, :bisection)
+    end
+
     it 'has an Internal Rate of Return on Bisection Method using a Guess' do
       assert_equal '0.225683'.to_f, @cf.xirr(0.15)
     end