Fix file-preview #169
Merged
Fix file-preview #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`invenio-app-rdm` isn't a dependency of ours, hence we can't use their `PreviewFile` class our `PreviewFile` also needs the `.record` attribute, as that is used in a jinja-template of the iiif-previewer
a built resource-config is similar to an unbuilt one, but may access the flask-app for computing some configs `IIIFResourceConfig` requires `app` for computing its `.proxy` attribute without this, image-preview was broken other `ResourceConfig`s don't have known-to-me issues due to this yet, but it might eventually be needed so I also added `.build` for resource-configs other than the `IIIF` one
utnapischtim
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.