Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error message #14

Open
max-moser opened this issue Sep 10, 2024 · 1 comment
Open

Improve the error message #14

max-moser opened this issue Sep 10, 2024 · 1 comment

Comments

@max-moser
Copy link
Collaborator

Right now, when the draft is saved, the error message says:

Record saved with validation errors:

    Unknown field: Missing curation request. Please create a curation request, if the record is ready to be published.

image


From my understanding this is done because the deposit form only shows certain hard-coded error types.
However, the curations aren't actually implemented via (custom) fields.
The error message itself is fine, but it would be nicer if the "Unknown field" weren't there.

@rekt-hard
Copy link
Contributor

Your assumption about certain error types is correct.
This was part of a first implementation with a separate UI box for curations. It was implemented this way, to make sure a user understands that a curation request is required before being able to publish. Since we now have a tight integration with the deposit box, the publish button will not be visible until after the curation request has been accepted.

In general: Maybe we can first tackle the question, if this should be reported as a validation error. Per se, the record does not know about a request. Updating a record should maybe only report validation errors on the record itself.
Also with the tight UI integration, the whole validation error might not be relevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants