Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hrpc/scan: add support for scan attribute #238

Merged
merged 1 commit into from
Nov 2, 2023
Merged

hrpc/scan: add support for scan attribute #238

merged 1 commit into from
Nov 2, 2023

Conversation

dethi
Copy link
Collaborator

@dethi dethi commented Nov 2, 2023

No description provided.

hrpc/scan.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f750f62) 70.10% compared to head (dd71e10) 70.18%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   70.10%   70.18%   +0.08%     
==========================================
  Files          27       27              
  Lines        3733     3780      +47     
==========================================
+ Hits         2617     2653      +36     
- Misses       1001     1007       +6     
- Partials      115      120       +5     
Files Coverage Δ
hrpc/scan.go 67.58% <66.66%> (-0.05%) ⬇️
rpc.go 84.86% <92.85%> (+0.12%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dethi dethi merged commit c4dd77b into master Nov 2, 2023
4 checks passed
@dethi dethi deleted the scan-attribute branch November 2, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants