SendBatch: Launch one fewer goroutine #230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
==========================================
- Coverage 70.29% 70.27% -0.03%
==========================================
Files 27 27
Lines 3720 3724 +4
==========================================
+ Hits 2615 2617 +2
- Misses 988 991 +3
+ Partials 117 116 -1
☔ View full report in Codecov by Sentry. |
dethi
requested changes
Aug 15, 2023
A small optimization to reduce the number of goroutines launched by SendBatch, while achieving the same parallelism. This is especially nice for SendBatch calls that only need to reach one Region Server, because then 0 additional goroutines need to be launched.
aaronbee
force-pushed
the
batchgoroutine
branch
from
cf46f47 to
e692a2f
Compare
|
I created #232 as an alternative to this PR. |
|
Superseded by #232 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small optimization to reduce the number of goroutines launched by SendBatch, while achieving the same parallelism. This is especially nice for SendBatch calls that only need to reach one Region Server, because then 0 additional goroutines need to be launched.
Also, changed
failfrom a bool + mutex to a uint32 that is atomically set to 1 on failure. This was primarily done to reduce lines of code.