Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sweep GHA Fix] Fix failing GitHub Actions run #91

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Jan 23, 2024

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement
    I created this PR to fix the failing GitHub Actions.## Description
    This PR fixes the failing GitHub Actions run by making necessary changes to the polyfills.ts file in the ionic-demo app. The failing run was related to the configuration of certain flags in the polyfills.ts file.

Summary of Changes

  • Modified the polyfills.ts file in the ionic-demo app.
  • Disabled the patch for the requestAnimationFrame by setting the flag (window as any).__Zone_disable_requestAnimationFrame = true;.
  • Disabled the patch for the onProperty events by setting the flag (window as any).__Zone_disable_on_property = true;.
  • Disabled the patch for specified eventNames (scroll and mousemove) by setting the flag (window as any).__zone_symbol__UNPATCHED_EVENTS = ['scroll', 'mousemove'];.

Please review and merge this PR to fix the failing GitHub Actions run.

Copy link
Contributor Author

sweep-ai bot commented Jan 23, 2024

Rollback Files For Sweep

  • Rollback changes to apps/ionic-demo/src/polyfills.ts
  • Rollback changes to apps/ionic-demo/src/polyfills.ts

@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Jan 23, 2024
Copy link

sweep-nightly bot commented Jan 23, 2024

Apply Sweep Rules to your PR?

  • Apply: There should not be large sections of commented out code.
  • Apply: All docstrings and comments should be up to date.

@matteobruni matteobruni merged commit a9cefd8 into main Jan 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant