Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development dosimetry metrics #19

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Development dosimetry metrics #19

merged 2 commits into from
Jun 18, 2024

Conversation

steffenhartmeyer
Copy link
Collaborator

Updated bright_dark_period

@steffenhartmeyer steffenhartmeyer requested a review from JZauner June 18, 2024 10:01
JZauner
JZauner approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@JZauner JZauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! For a future revision, a check for 24-Hours when loop=true would be good. Basically what you already had with span + epoch == 24 hours.

@JZauner JZauner merged commit 8e559c9 into main Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JZauner JZauner JZauner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steffenhartmeyer @JZauner