add 4 pin crystal symbol #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ni9999
requested review from
seveibar,
Timer00 and
imrishabh18
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
seveibar
requested changes
Nov 19, 2024
symbols/crystal_4pin_horz.ts
Outdated
| ], | ||
| size: { width: bounds.width, height: bounds.height }, | ||
| center: { x: bounds.centerX, y: bounds.centerY }, | ||
| }) |
There was a problem hiding this comment.
use modifySymbol instead
please label pins 2 and 4 "gnd1", "gnd2"
|
@ni9999 nice work, was happy to see this |
|
@seveibar now it looks like this |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
seveibar
reviewed
Nov 23, 2024
symbols/crystal_4pin_horz.ts
Outdated
Comment on lines
5
to
6
| .labelPort("top1", ["gnd1"]) | ||
| .labelPort("bottom1", ["gnd2"]) |
There was a problem hiding this comment.
Suggested change
| .labelPort("top1", ["gnd1"]) | |
| .labelPort("bottom1", ["gnd2"]) | |
| .labelPort("top1", ["2", "gnd1"]) | |
| .labelPort("bottom1", ["4", "gnd2"]) |
|
@seveibar accepted but now gnd1 and gnd2 is gone |
seveibar
approved these changes
Nov 24, 2024
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
@ni9999 im eager to merge this but it has conflicts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #202
/claim #202