Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all footprinter functions by updating its scheme, all footprints now have default value of num_pins #83

Merged
merged 12 commits into from
Nov 20, 2024

Conversation

anas-sarkez
Copy link
Member

/claim #75
/closes #75

src/fn/bga.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 main things,

when using default i think you need optional iirc

lets not import number, it overlaps the typescript type

@anas-sarkez
Copy link
Member Author

2 main things,

when using default i think you need optional iirc

lets not import number, it overlaps the typescript type

check last commit

src/fn/pinrow.ts Outdated Show resolved Hide resolved
@anas-sarkez anas-sarkez merged commit 24dcd87 into tscircuit:main Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants