style(ui): [toaster] add colors for different states #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okt-limonikas
changed the title
okt-limonikas
requested review from
arybchik and
k0nstantin
and removed request for
arybchik
okt-limonikas
force-pushed
the
limonikas/toaster-colors
branch
from
996626c
to
81fb904
Compare
okt-kostik
reviewed
Jan 12, 2024
| @@ -19,7 +19,11 @@ const Toaster = ({ ...props }: ToasterProps) => { | |||
| actionButton: | |||
There was a problem hiding this comment.
Sorry, which states, which view, why?
There was a problem hiding this comment.
It's not one view, it's for notification system in case we show some message.
Currently it's in monochrome tone so added colours
Commit message improved
okt-limonikas
requested review from
okt-kostik
and removed request for
k0nstantin
okt-limonikas
force-pushed
the
limonikas/toaster-colors
branch
from
81fb904
to
e622484
Compare
okt-kostik
approved these changes
Jan 16, 2024
okt-limonikas
force-pushed
the
limonikas/toaster-colors
branch
from
e622484
to
31730c8
Compare
Added different icon colors for different toast types e.g. success|warning|info|error, so it's easier to distinguish if something failed, or it's some general information or tip message Signed-off-by: Danil Kostromin <[email protected]>
okt-limonikas
force-pushed
the
limonikas/toaster-colors
branch
from
1f66a51
to
2955b94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds colors for different states and variants of toast e.g warning/error/success