Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nx): upgrade nx to latest version and remove unused imports #7

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

okt-limonikas
Copy link
Collaborator

@okt-limonikas okt-limonikas commented Jan 12, 2024

This PR upgrades NX and fixes multiple linting errors for unused imports/types
This serves as a base for next PR's since it fixes tests and some quirks around configs

@okt-limonikas okt-limonikas marked this pull request as draft January 12, 2024 17:32
@okt-limonikas okt-limonikas changed the title Cleanup lint errors chore(storybook): cleanup unused imports/types and linting errors Jan 12, 2024
@okt-limonikas okt-limonikas self-assigned this Jan 12, 2024
@okt-limonikas okt-limonikas marked this pull request as ready for review January 12, 2024 19:25
@okt-limonikas okt-limonikas added the 🐛 Bug Something isn't working label Jan 12, 2024
@okt-limonikas okt-limonikas requested review from k0nstantin and removed request for arybchik January 12, 2024 20:01
@okt-limonikas okt-limonikas changed the title chore(storybook): cleanup unused imports/types and linting errors chore(nx): upgrade nx to latest version and remove unused imports Jan 12, 2024
@okt-limonikas okt-limonikas requested review from okt-kostik and removed request for k0nstantin January 12, 2024 21:19
tsconfig.base.json Show resolved Hide resolved
apps/bublik/types/mdx.d.ts Show resolved Hide resolved
okt-kostik
okt-kostik previously approved these changes Jan 16, 2024
apps/bublik/types/mdx.d.ts Show resolved Hide resolved
Danil Kostromin added 2 commits January 17, 2024 14:12
Changes:
- Remove unused import/types
- Add comments where necessary to ignore linting

Signed-off-by: Danil Kostromin <[email protected]>
@okt-limonikas okt-limonikas merged commit e1039f2 into main Jan 17, 2024
1 check passed
@okt-limonikas okt-limonikas deleted the limonikas/cleanup-storybook branch January 17, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants