-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(nx): upgrade nx to latest version and remove unused imports #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okt-limonikas
force-pushed
the
limonikas/cleanup-storybook
branch
from
January 12, 2024 19:20
db79243
to
efe83bd
Compare
okt-limonikas
changed the title
Cleanup lint errors
chore(storybook): cleanup unused imports/types and linting errors
Jan 12, 2024
okt-limonikas
requested review from
k0nstantin
and removed request for
arybchik
January 12, 2024 20:01
okt-limonikas
changed the title
chore(storybook): cleanup unused imports/types and linting errors
chore(nx): upgrade nx to latest version and remove unused imports
Jan 12, 2024
okt-limonikas
force-pushed
the
limonikas/cleanup-storybook
branch
from
January 12, 2024 21:16
efe83bd
to
9ed14e4
Compare
okt-kostik
approved these changes
Jan 12, 2024
okt-limonikas
requested review from
okt-kostik
and removed request for
k0nstantin
January 12, 2024 21:19
okt-kostik
requested changes
Jan 16, 2024
okt-limonikas
force-pushed
the
limonikas/cleanup-storybook
branch
from
January 16, 2024 17:38
9ed14e4
to
23c6cfe
Compare
okt-kostik
previously approved these changes
Jan 16, 2024
Signed-off-by: Danil Kostromin <[email protected]>
Changes: - Remove unused import/types - Add comments where necessary to ignore linting Signed-off-by: Danil Kostromin <[email protected]>
okt-limonikas
force-pushed
the
limonikas/cleanup-storybook
branch
from
January 17, 2024 12:14
c5bd95a
to
e1039f2
Compare
arybchik
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades NX and fixes multiple linting errors for unused imports/types
This serves as a base for next PR's since it fixes tests and some quirks around configs