Skip to content

Commit

Permalink
ci(release,ci): fix formatting and pass env through global config
Browse files Browse the repository at this point in the history
Changes:
- Fix indentation in CI config
- Disable playwright browser install trough global env config

Signed-off-by: Danil Kostromin <[email protected]>
  • Loading branch information
Danil Kostromin committed Jan 16, 2024
1 parent 5bd5778 commit 23474cf
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 48 deletions.
74 changes: 29 additions & 45 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,45 +1,29 @@
name: CI
on:
pull_request:
branches: [main]
jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [20]
steps:
- name: Code Checkout
uses: actions/checkout@v4
- uses: pnpm/action-setup@v2
with:
version: 8
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'pnpm'
- name: Install dependencies
run: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 pnpm install
- name: Code Testing
run: pnpm run test
lint:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [20]
steps:
- name: Code Checkout
uses: actions/checkout@v4
- uses: pnpm/action-setup@v2
with:
version: 8
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'pnpm'
- name: Install dependencies
run: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 pnpm install
- name: Code Linting
run: pnpm run lint
name: CI
on:
pull_request:
branches: [main]
env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [20]
steps:
- name: Code Checkout
uses: actions/checkout@v4
- uses: pnpm/action-setup@v2
with:
version: 8
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'pnpm'
- name: Install dependencies
run: pnpm install
- name: Code Linting
run: pnpm run lint
- name: Code Testing
run: pnpm run test
8 changes: 5 additions & 3 deletions .github/workflows/create-release-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ on:
type: boolean
description: Dry release
default: false
env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
jobs:
test:
runs-on: ubuntu-latest
Expand All @@ -37,7 +39,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'pnpm'
- name: Install dependencies
run: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 pnpm install
run: pnpm install
- name: Code Testing
run: pnpm run test
lint:
Expand All @@ -57,7 +59,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'pnpm'
- name: Install dependencies
run: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 pnpm install
run: pnpm install
- name: Code Linting
run: pnpm run lint
release:
Expand All @@ -83,7 +85,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'pnpm'
- name: Install dependencies
run: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 pnpm install
run: pnpm install
- name: Create release
run: pnpm run release --ci --verbose $TYPE_ARG $BETA_ARG $DRY_ARG
env:
Expand Down

0 comments on commit 23474cf

Please sign in to comment.