[chore] Add code executor pdb + prestop hook for backend #198
+29
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
june-xu
force-pushed
the
june/onprem-prework
branch
from
7d4a176 to
a40d610
Compare
june-xu
force-pushed
the
june/onprem-prework
branch
from
a40d610 to
112aa87
Compare
june-xu
force-pushed
the
june/onprem-prework
branch
from
112aa87 to
cbba1d6
Compare
jjlgao
reviewed
Dec 16, 2024
| lifecycle: | ||
| preStop: | ||
| exec: | ||
| command: ["sleep", "30"] |
There was a problem hiding this comment.
I thought this only needed to be 15 secs?
There was a problem hiding this comment.
wanted to wait for longer in-flight requests
jjlgao
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve reliability and resiliency of the services!